fix(compiler): align call gas accounting with interpreter#311
Merged
zoowii merged 7 commits intoDTVMStack:mainfrom Feb 6, 2026
Merged
fix(compiler): align call gas accounting with interpreter#311zoowii merged 7 commits intoDTVMStack:mainfrom
zoowii merged 7 commits intoDTVMStack:mainfrom
Conversation
starwarfan
reviewed
Jan 29, 2026
Contributor
There was a problem hiding this comment.
#312 is for interpreter to pass the evmone unittest.
You change fails the evmone unittest for multipass.
[ FAILED ] multi_vm/evm.call_failing_with_value/external_vm, where GetParam() = 0x602000006f10
[ FAILED ] multi_vm/evm.call_new_account_creation_cost/external_vm, where GetParam() = 0x602000006f10
Looks like the state test you tend to fix conflicts with evmone's unittest.
Contributor
|
conflict |
zoowii
reviewed
Feb 5, 2026
| constexpr bool PRINT_FAILURE_DETAILS = true; | ||
| // TODO: RunMode selection logic will be refactored in the future. | ||
| constexpr auto STATE_TEST_RUN_MODE = common::RunMode::MultipassMode; | ||
| constexpr auto STATE_TEST_RUN_MODE = common::RunMode::InterpMode; |
Contributor
There was a problem hiding this comment.
why change to InterpMode by default
Contributor
|
It seems these |
Contributor
Author
evm_interp_tests then scans all .evm.hex files and fails if a matching .expected is missing.So these .expected files are not redundant—they are the missing golden outputs for shift tests that are now actually executed. Removing them would make the interpreter tests fail unless we also stop generating those .evm.hex files or relax the test requirements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note